🛡️ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract - #151
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
jsonExtractutility function inpackages/core/src/db/database-wrapper.tsusedsql.raw()to dynamically interpolate JSON path keys into PostgreSQL query strings. Sincesql.raw()disables Drizzle's parameterization, any untrusted data passed as part of the JSON path could result in SQL injection.🎯 Impact: An attacker could craft a malicious JSON path containing unescaped SQL syntax (like quotes or comments) to manipulate queries generated by the application, potentially leading to unauthorized data access, modification, or database compromise.
🔧 Fix: Replaced the
sql.raw()concatenations with parameterized template literals (sql\->(${p}::text)`). Specifically, explicitly casting the variables to::textresolves the PostgreSQL JSON operator overloading issue ("operator does not exist: jsonb -> unknown") that previously necessitated the unsafe workaround. ✅ **Verification:** Ran the full unit test suite for@agor/core(pnpm --filter @agor/core test) which passed successfully. Linters were checked, and a Sentinel journal entry was added to.jules/sentinel.md` documenting this learning to prevent future occurrences.PR created automatically by Jules for task 2303475847528674488 started by @Donach